Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16348 )
Change subject: IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16348/1/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/16348/1/tests/custom_cluster/test_kudu.py@39 PS1, Line 39: def add_test_dimensions(cls): I think its a little cleaner if you override add_custom_cluster_constraints() instead, then just don't call super() and you won't need clear_constraints(), see eg. TestLocalTzConversion -- To view, visit http://gerrit.cloudera.org:8080/16348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60a4bd4ac5a9026629fb840ab9cc7b5f9948290c Gerrit-Change-Number: 16348 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2020 16:20:13 +0000 Gerrit-HasComments: Yes
