Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16348 )
Change subject: IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster ...................................................................... Patch Set 3: Code-Review+2 > > Patch Set 1: > > > > (1 comment) > > Thanks Thomas for the pointer! In this regard, I have overridden > add_custom_cluster_constraints() so that I do not have to call > clear_constraints(). > > But I do have a related question. It looks like in > CustomClusterTestSuite.add_custom_cluster_constraints(), > super(CustomClusterTestSuite, cls).add_test_dimensions() at > https://github.com/apache/impala/blob/master/tests/common/custom_cluster_test_suite.py#L77 > is called immediately after > https://github.com/apache/impala/blob/master/tests/common/custom_cluster_test_suite.py#L69, > which makes the second call seem redundant. I guess probably have > missed something important. Agreed. It looks like https://github.com/apache/impala/blob/master/tests/common/custom_cluster_test_suite.py#L77 was just a mistake. Its not really hurting anything, so you can just ignore it and submit the patch as-is, or feel free to update the patch to remove that line if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/16348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60a4bd4ac5a9026629fb840ab9cc7b5f9948290c Gerrit-Change-Number: 16348 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2020 21:03:34 +0000 Gerrit-HasComments: No
