Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 )
Change subject: IMPALA-7658: Proper codegen for HiveUdfCall ...................................................................... Patch Set 10: Code-Review+2 (2 comments) I'm happy with this modulo confirming testing. http://gerrit.cloudera.org:8080/#/c/16314/10/be/src/exprs/hive-udf-call-ir.cc File be/src/exprs/hive-udf-call-ir.cc: http://gerrit.cloudera.org:8080/#/c/16314/10/be/src/exprs/hive-udf-call-ir.cc@84 PS10, Line 84: if (type->type == TYPE_STRING) { > I implemented string copying here instead of a separate cross-compiled 'Cop Yeah, I see you're using ColumnType::ToIR() so the type should be propagated (assuming inlining, etc, but that's reasonable). This makes sense to me. http://gerrit.cloudera.org:8080/#/c/16314/10/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: http://gerrit.cloudera.org:8080/#/c/16314/10/be/src/exprs/hive-udf-call.cc@266 PS10, Line 266: // TODO: Check if Timestamp works. It is currently not supported in Hive Do we have a negative test calling a hive UDF with a timestamp that would start failing if this changed? -- To view, visit http://gerrit.cloudera.org:8080/16314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f994dac550f297ed3c88491816403f237d4d747 Gerrit-Change-Number: 16314 Gerrit-PatchSet: 10 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2020 17:38:45 +0000 Gerrit-HasComments: Yes
