Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 )
Change subject: IMPALA-7658: Proper codegen for HiveUdfCall ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/16314/11/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: http://gerrit.cloudera.org:8080/#/c/16314/11/be/src/exprs/hive-udf-call.cc@273 PS11, Line 273: else { : llvm::Value* child_value = child->GetVal("child_value"); : return codegen->GetPtrTo(builder, child_value, "child_val_ptr"); : } I realised we don't need to branch here, ToNativePtr should work for all types. I'll remove this function. -- To view, visit http://gerrit.cloudera.org:8080/16314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f994dac550f297ed3c88491816403f237d4d747 Gerrit-Change-Number: 16314 Gerrit-PatchSet: 11 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2020 14:54:43 +0000 Gerrit-HasComments: Yes
