Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16377 )
Change subject: IMPALA-10110: allow setting bloom filter fpp ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Non critical suggestions. Thanks for the fix! http://gerrit.cloudera.org:8080/#/c/16377/4/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/16377/4/be/src/service/query-options.h@50 PS4, Line 50: RUNTIME_FILTER_FPP I don't feel strongly about this so either way. "FPP" is kind of an opaque technical term. Since this might be user facing and we've got a flag already called "max_filter_error_rate" which is wordier as a query option but incorporating FILTER_ERROR_RATE instead of FPP might make the option more self documenting. http://gerrit.cloudera.org:8080/#/c/16377/4/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/16377/4/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@146 PS4, Line 146: max_filter_error_rate Would you mind updating the flag doc to mention the query option as an override? https://github.com/apache/impala/blob/03f2b559c31af7fc11165cf3b00876900e234663/be/src/runtime/runtime-filter-bank.cc#L56 -- To view, visit http://gerrit.cloudera.org:8080/16377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb123a0ea1e0e95d95df9837c1f0222fd60361f3 Gerrit-Change-Number: 16377 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2020 22:24:58 +0000 Gerrit-HasComments: Yes
