Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16377 )
Change subject: IMPALA-10110: bloom filter target fpp query option ...................................................................... Patch Set 5: (1 comment) Addressed your one comment. I won't carry +2 but should be easy to review the small diff. http://gerrit.cloudera.org:8080/#/c/16377/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16377/5//COMMIT_MSG@26 PS5, Line 26: 1.0439491515673421e-37 > might be nice to truncate this, eg. to two decimal places with PrettyPrinte I had the same thought but couldn't find a good solution first time around since I wanted something that would behave reasonably with small fpp. I took another look and it looks like stringstream with setprecision switches to scientific notation for small values so that works well. -- To view, visit http://gerrit.cloudera.org:8080/16377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb123a0ea1e0e95d95df9837c1f0222fd60361f3 Gerrit-Change-Number: 16377 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2020 22:47:10 +0000 Gerrit-HasComments: Yes
