Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16348 )
Change subject: IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster ...................................................................... IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster We found that the following 4 tests do not run even we remove all the decorators like "@SkipIfKudu.no_hybrid_clock" or "@SkipIfHive3.kudu_hms_notifications_not_supported" to skip the tests. This is due to the fact that those 3 classes inherit the class of CustomClusterTestSuite, which adds a constraint that only allows test vectors with 'file_format' and 'compression_codec' being "text" and "none", respectively, to be run. 1. TestKuduOperations::test_local_tz_conversion_ops 2. TestKuduClientTimeout::test_impalad_timeout 3. TestKuduHMSIntegration::test_create_managed_kudu_tables 4. TestKuduHMSIntegration::test_kudu_alter_table To address this issue, in this patch we create a parent class for those 3 classes above and override the method of add_custom_cluster_constraints() for this newly created parent class so that we do not skip test vectors with 'file_format' and 'compression_codec' being "kudu" and "none", respectively. On the other hand, this patch also removes a redundant method call to super(CustomClusterTestSuite, cls).add_test_dimensions() in CustomClusterTestSuite.add_custom_cluster_constraints() since super(CustomClusterTestSuite, cls).add_test_dimensions() had already been called immediately before the call to add_custom_cluster_constraints() in CustomClusterTestSuite.add_test_dimensions(). Testing: - Manually verified that after removing the decorators to skip those tests, those tests could be run. Change-Id: I60a4bd4ac5a9026629fb840ab9cc7b5f9948290c Reviewed-on: http://gerrit.cloudera.org:8080/16348 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_kudu.py 2 files changed, 23 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I60a4bd4ac5a9026629fb840ab9cc7b5f9948290c Gerrit-Change-Number: 16348 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
