Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16389 )
Change subject: IMPALA-10051: impala-shell exits with ValueError with WITH clauses ...................................................................... Patch Set 2: (1 comment) Thanks for the review Fredy. Fixed the dry-run test, the assert was dev env specific, my test table was empty. http://gerrit.cloudera.org:8080/#/c/16389/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/16389/2/shell/impala_shell.py@1280 PS2, Line 1280: if self.DML_REGEX.match(query_type.lower()): > looks like there were failed tests in the dry-run Right, it is cleaner this way. Done. -- To view, visit http://gerrit.cloudera.org:8080/16389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I442d3bc65b90a55c73c847948d5179a8586d71ad Gerrit-Change-Number: 16389 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 01 Sep 2020 11:54:45 +0000 Gerrit-HasComments: Yes
