Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16389 )
Change subject: IMPALA-10051: impala-shell exits with ValueError with WITH clauses ...................................................................... Patch Set 4: (2 comments) Looks good to me. Use of sql parser to classify a query is the right way to go. http://gerrit.cloudera.org:8080/#/c/16389/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16389/4//COMMIT_MSG@9 PS4, Line 9: a nit: removal? http://gerrit.cloudera.org:8080/#/c/16389/4/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/16389/4/tests/shell/test_shell_interactive.py@1059 PS4, Line 1059: applied to avoid nit: reworded as 'prevents' -- To view, visit http://gerrit.cloudera.org:8080/16389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I442d3bc65b90a55c73c847948d5179a8586d71ad Gerrit-Change-Number: 16389 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2020 14:35:39 +0000 Gerrit-HasComments: Yes
