Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16408
Change subject: IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats ...................................................................... IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats This work addresses the data race by properly initializing two data member is_query_mem_tracker_ and query_id_ in a constructor for the MemTracker class. Without doing so, the two data members are set after the object is constructed. This creates a race condition for other threads to modify either of them at the same time. Testing: 1. Ran the python admission controller test successfully with a tsan build. Data race was not observed with the enhancement. Data race was observed without the enhancement. 2. Ran the core test. Change-Id: I9c4ffe8064d3e099a525cc48c218ef73112fb67b --- M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h 2 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/16408/3 -- To view, visit http://gerrit.cloudera.org:8080/16408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9c4ffe8064d3e099a525cc48c218ef73112fb67b Gerrit-Change-Number: 16408 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
