Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16408 )
Change subject: IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats ...................................................................... IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats This work addresses a data race condition in admission controller by providing the initializing values for two data members ( is_query_mem_tracker_ and query_id_) in a constructor for the MemTracker class. Without doing so, the two data members are set, without lock protection, after the object is constructed, which allows other threads to modify either of them at the same time. Testing: 1. Ran the python admission controller test successfully with a tsan build. Data race was not observed with the enhancement. Data race was observed without the enhancement. 2. Ran the core test. Change-Id: I9c4ffe8064d3e099a525cc48c218ef73112fb67b --- M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h 2 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/16408/4 -- To view, visit http://gerrit.cloudera.org:8080/16408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c4ffe8064d3e099a525cc48c218ef73112fb67b Gerrit-Change-Number: 16408 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]>
