Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 )
Change subject: [WIP] IMPALA-9930 (part 2): Introduce new admission control rpc service ...................................................................... Patch Set 1: (20 comments) http://gerrit.cloudera.org:8080/#/c/16412/1/be/src/scheduling/admission-control-client.cc File be/src/scheduling/admission-control-client.cc: http://gerrit.cloudera.org:8080/#/c/16412/1/be/src/scheduling/admission-control-client.cc@210 PS1, Line 210: LOG(WARNING) << "ReleaseQueryBackends failed for " << query_id_ << ": " << resp_status; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16412/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/16412/1/be/src/scheduling/admission-controller.h@339 PS1, Line 339: std::unique_ptr<QuerySchedulePB>* schedule_result, bool* queued, std::string* request_pool = nullptr); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/16412/1/be/src/scheduling/admission-controller.h@343 PS1, Line 343: int64_t timeout_ms = 0, bool* wait_timed_out = nullptr, std::string* request_pool = nullptr); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/16412/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16412/1/be/src/scheduling/admission-controller.cc@1116 PS1, Line 1116: unique_ptr<QuerySchedulePB>* schedule_result, bool* queued, std::string* request_pool) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16412/1/be/src/scheduling/admission-controller.cc@1292 PS1, Line 1292: ErrorMsg(TErrorCode::ADMISSION_TIMED_OUT, queue_wait_timeout_ms, queue_node->pool_name, line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@602 PS1, Line 602: s flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@803 PS1, Line 803: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@816 PS1, Line 816: t flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@1082 PS1, Line 1082: r flake8: E501 line too long (113 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@1140 PS1, Line 1140: " flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@1287 PS1, Line 1287: s flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@1318 PS1, Line 1318: _ flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@1321 PS1, Line 1321: flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@1903 PS1, Line 1903: class TestAdmissionControllerStressWithACService(TestAdmissionControllerStress): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@1919 PS1, Line 1919: _ flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/custom_cluster/test_admission_controller.py@1922 PS1, Line 1922: flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16412/1/tests/hs2/hs2_test_suite.py File tests/hs2/hs2_test_suite.py: http://gerrit.cloudera.org:8080/#/c/16412/1/tests/hs2/hs2_test_suite.py@338 PS1, Line 338: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/16412/1/tests/hs2/hs2_test_suite.py@338 PS1, Line 338: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/16412/1/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/16412/1/tests/run-tests.py@317 PS1, Line 317: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/16412/1/tests/run-tests.py@335 PS1, Line 335: # flake8: E265 block comment should start with '# ' -- To view, visit http://gerrit.cloudera.org:8080/16412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I594fc593a27b24b6952e381a9bc1a9a5c6b757ae Gerrit-Change-Number: 16412 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2020 20:39:56 +0000 Gerrit-HasComments: Yes
