Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 )
Change subject: [WIP] IMPALA-9930 (part 2): Introduce new admission control rpc service ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16412/3/be/src/scheduling/admission-control-client.cc File be/src/scheduling/admission-control-client.cc: http://gerrit.cloudera.org:8080/#/c/16412/3/be/src/scheduling/admission-control-client.cc@31 PS3, Line 31: const string AdmissionControlClient::QUERY_EVENT_SUBMIT_FOR_ADMISSION = "Submit for admission"; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/16412/3/be/src/scheduling/admission-control-client.cc@33 PS3, Line 33: const string AdmissionControlClient::QUERY_EVENT_COMPLETED_ADMISSION = "Completed admission"; line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16412/3/be/src/scheduling/schedule-state.h File be/src/scheduling/schedule-state.h: http://gerrit.cloudera.org:8080/#/c/16412/3/be/src/scheduling/schedule-state.h@150 PS3, Line 150: /// For testing only: specify 'init=false' to build a ScheduleState object but do not run Init(). line too long (99 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I594fc593a27b24b6952e381a9bc1a9a5c6b757ae Gerrit-Change-Number: 16412 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2020 01:20:26 +0000 Gerrit-HasComments: Yes
