Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16414

to look at the new patch set (#2).

Change subject: WIP IMPALA-9046: Profile counter that indicates if a JVM pause 
occurred
......................................................................

WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred

Adds a new section to the host profiles that includes JVM GC related
metrics. These metrics are taken from JMX and the JvmPauseMonitor.

The host profiles will now include a section like below:

        JVM:
           - GcCount: 19
           - GcNumInfoThresholdExceeded: 0
           - GcNumWarnThresholdExceeded: 0
           - GcTimeMillis: 17s476ms
           - GcTotalExtraSleepTimeMillis: 380

GcNumInfoThresholdExceeded, GcNumWarnThresholdExceeded, and
GcTotalExtraSleepTimeMillis are all taken from JvmPauseMonitor.
GcCount and GcTimeMillis are taken from JMX (specifically,
GarbageCollectorMXBean).

The counters themselves are derived from the impalad host-level metrics.

Testing:
* Added a test that runs Java UDF, which triggers JVM GC

TODO:
* Run core tests
* Considering re-working JvmMetricCache::lock_ usage to reduce
  potential lock contention

Change-Id: Idbaae2f9142b8be94532a0a147668a3d96091b0b
---
M be/src/runtime/query-state.cc
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
A tests/custom_cluster/test_observability.py
A tests/test-hive-udfs/src/main/java/org/apache/impala/JavaGcUdfTest.java
5 files changed, 185 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/16414/2
--
To view, visit http://gerrit.cloudera.org:8080/16414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idbaae2f9142b8be94532a0a147668a3d96091b0b
Gerrit-Change-Number: 16414
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>

Reply via email to