Qifan Chen has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/16373 )
Change subject: WIP IMPALA-4065 Inline comparator calls into TopN::InsertBatch() ...................................................................... WIP IMPALA-4065 Inline comparator calls into TopN::InsertBatch() This work addresses the current limitation in TopN node by replaing the std::priority_queue with an in-house implementation. In this way, it is feasible to call more efficient version of comparator when comparing tuples during the selection of top n values. The in-house version of the priority queue is LLVM code-gened. Testing: 1. Added a new test TestBasic in a new test harness priority-queue-test.cc to verify that the priority queue works properly. 2. Ran Core tests successfully. TODO: 1. llvm code gen for entire TopNNode::InsertBatch(); 2. Performance testing. Change-Id: I676b4c05cf10a6946c05e317b0002c1e29e78aa8 --- M be/src/exec/topn-node-ir.cc M be/src/exec/topn-node.cc M be/src/exec/topn-node.h M be/src/util/CMakeLists.txt A be/src/util/comparator.h A be/src/util/priority-queue-test.cc A be/src/util/priority-queue.h M be/src/util/tuple-row-compare.cc M be/src/util/tuple-row-compare.h 9 files changed, 384 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/16373/12 -- To view, visit http://gerrit.cloudera.org:8080/16373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I676b4c05cf10a6946c05e317b0002c1e29e78aa8 Gerrit-Change-Number: 16373 Gerrit-PatchSet: 12 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
