Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16373 )
Change subject: WIP IMPALA-4065 Inline comparator calls into TopN::InsertBatch() ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/16373/9/be/src/util/priority-queue.h File be/src/util/priority-queue.h: http://gerrit.cloudera.org:8080/#/c/16373/9/be/src/util/priority-queue.h@81 PS9, Line 81: public: > Can't we pass in TupleRowComparator directly? ComparatorWrapper was just us Done -- To view, visit http://gerrit.cloudera.org:8080/16373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I676b4c05cf10a6946c05e317b0002c1e29e78aa8 Gerrit-Change-Number: 16373 Gerrit-PatchSet: 12 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 05 Sep 2020 01:57:24 +0000 Gerrit-HasComments: Yes
