Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16423 )
Change subject: IMPALA-10122 (Part 1): Deny access to views not authorized at creation ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3078 PS1, Line 3078: // When 'table' is null, we also assume that 'table' does not correspond to a view whose line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3091 PS1, Line 3091: // When 'table' is null, we also assume that 'table' does not correspond to a view whose line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java File fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java: http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java@179 PS1, Line 179: // 'viewCreatedWithoutAuthz' once we can properly process a PrivilegeRequest for line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java@185 PS1, Line 185: // TODO(IMPALA-10122): Remove the need for computing 'isViewCreatedWithoutAuthz' line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java@186 PS1, Line 186: // once we can properly process a PrivilegeRequest for a view whose creation was line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java@193 PS1, Line 193: // We assume that 'table' is not a view whose creation was not authorized if we line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java@199 PS1, Line 199: tbl.getOwnerUser(), isViewCreatedWithoutAuthz).allOf(Privilege.REFRESH) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java File fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java: http://gerrit.cloudera.org:8080/#/c/16423/1/fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java@121 PS1, Line 121: String dbName, String tableName, String ownerUser, boolean viewCreatedWithoutAuthz) { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73965e05586771de85fa6f73c452e3de4f312034 Gerrit-Change-Number: 16423 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Sun, 06 Sep 2020 23:09:23 +0000 Gerrit-HasComments: Yes
