Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16423 )
Change subject: IMPALA-10122 (Part 1): Deny access to views not authorized at creation ...................................................................... Patch Set 5: (3 comments) The patch looks good to me now. Will give +2 after resolving some minor comments. http://gerrit.cloudera.org:8080/#/c/16423/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16423/5//COMMIT_MSG@55 PS5, Line 55: Recall that Impala : does not support the ALTER VIEW SET TBLPROPERTIES statement. What about the supported ALTER VIEW statements? https://impala.apache.org/docs/build/html/topics/impala_alter_view.html Are they denied as well for such kind of views? http://gerrit.cloudera.org:8080/#/c/16423/3/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/16423/3/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@241 PS3, Line 241: hen config_.isEnabl > Thanks Quanlong! I added this check because this method (authorizeTableAcce Thanks for the explanation! http://gerrit.cloudera.org:8080/#/c/16423/5/fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java File fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java: http://gerrit.cloudera.org:8080/#/c/16423/5/fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java@83 PS5, Line 83: table == null || nit: don't need this since (null instanceof View) is false. https://stackoverflow.com/questions/2950319/is-null-check-needed-before-calling-instanceof -- To view, visit http://gerrit.cloudera.org:8080/16423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73965e05586771de85fa6f73c452e3de4f312034 Gerrit-Change-Number: 16423 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 09 Sep 2020 01:34:11 +0000 Gerrit-HasComments: Yes
