Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16428 )

Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/16428/1/fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java
File fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java:

http://gerrit.cloudera.org:8080/#/c/16428/1/fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java@218
PS1, Line 218:         new 
org.apache.hadoop.hive.ql.metadata.PrimaryKeyInfo(table.getSqlConstraints().getPrimaryKeys(),
 table.getName(), table.getDb().getName());
line too long (148 > 90)


http://gerrit.cloudera.org:8080/#/c/16428/1/fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java@221
PS1, Line 221:         new 
org.apache.hadoop.hive.ql.metadata.ForeignKeyInfo(table.getSqlConstraints().getForeignKeys(),
 table.getName(), table.getDb().getName());
line too long (148 > 90)


http://gerrit.cloudera.org:8080/#/c/16428/1/tests/metadata/test_metadata_query_statements.py
File tests/metadata/test_metadata_query_statements.py:

http://gerrit.cloudera.org:8080/#/c/16428/1/tests/metadata/test_metadata_query_statements.py@137
PS1, Line 137: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/16428/1/tests/metadata/test_metadata_query_statements.py@141
PS1, Line 141: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/16428/1/tests/metadata/test_metadata_query_statements.py@145
PS1, Line 145: \
flake8: E502 the backslash is redundant between brackets



--
To view, visit http://gerrit.cloudera.org:8080/16428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676b69c465c46491f870d7fdc894e7474c030356
Gerrit-Change-Number: 16428
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 08 Sep 2020 20:46:17 +0000
Gerrit-HasComments: Yes

Reply via email to