Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16428 )
Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Will check with David and Vihang if they're plannign to look http://gerrit.cloudera.org:8080/#/c/16428/1/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveMetadataFormatUtils.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveMetadataFormatUtils.java: http://gerrit.cloudera.org:8080/#/c/16428/1/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveMetadataFormatUtils.java@423 PS1, Line 423: .intern() > Yup, just copied from Hive like that https://github.com/apache/hive/blob/ma OK. Let's keep the codes the same as Hive's (to make things simpler), unless they have critical issues. Please ignore these nits. -- To view, visit http://gerrit.cloudera.org:8080/16428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I676b69c465c46491f870d7fdc894e7474c030356 Gerrit-Change-Number: 16428 Gerrit-PatchSet: 1 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 14 Sep 2020 09:56:44 +0000 Gerrit-HasComments: Yes
