Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 12: I was thinking about two managed Iceberg tables using the same hadoop catalog location. If I understand correctly, in CREATE TABLE we can provide the location of the HadoopCatalog, i.e. a directory in HDFS. Then the actual table location is derived from the HadoopCatalog location + DB_NAME + TABLE_NAME. So in the end the Iceberg table will be located at some directory like: hdfs://test-warehouse/iceberg-hadoop-catalog/my_database/my_table And if we create a second managed table with the same HadoopCatalog location, it will be placed at: hdfs://test-warehouse/iceberg-hadoop-catalog/my_database_2/my_table_2 But in the Hive Metastore, for table location we only store hdfs://test-warehouse/iceberg-hadoop-catalog/, right? So if my understanding is correct, on DROP TABLE we might delete the whole hdfs://test-warehouse/iceberg-hadoop-catalog/ directory. Or maybe I misunderstood something? But adding such test is useful anyway in my opinion. -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 12 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Thu, 24 Sep 2020 08:37:40 +0000 Gerrit-HasComments: No
