wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 12: > > Thanks for fixing the test! > > Currently I'm wondering about DROP TABLE. Could you please add a > > test that creates two Iceberg tables in the same HadoopCatalog, > > DROP one of them and check that the other one still exists. > > Could you please also add a DESCRIBE EXTENDED test to check the > > TBLPROPERTIES and LOCATION? > > Hi Zoltan, I don't understand about "creates two Iceberg tables in > the same HadoopCatalog". Do you mean create two managed table with > HadoopCatalog in different location? Or create two external table > with HadoopCatalog in same location? Or create a managed table, and > create a external location to this managed table? Thanks for your patient explain, Zoltan, and I understand. Of course your understanding is totally correct! I will add this test case lately. Another question is for 'DESCRIBE EXTENDED table', the result will returns lots of information, how do I define '---- RESULTS' in test file? Use 'row_regex' to filter some info or list all values like this: '# col_name','data_type','comment' '','NULL','NULL' 'id','int','NULL' 'user','string','NULL' ... I didn't found any case of 'DESCRIBE EXTENDED table' in 'testdata/workloads/functional-query/queries/QueryTest', only found 'describe database extended xxx', which is very different from 'DESCRIBE EXTENDED xxx': ---- RESULTS '','$USER','USER' 'Owner: ','','' 'impala_test_desc_db1','$NAMENODE/$EXTERNAL_WAREHOUSE_DIR/impala_test_desc_db1.db','' -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 12 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2020 09:00:41 +0000 Gerrit-HasComments: No
