Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16502 )
Change subject: IMPALA-9870: impala-shell 'summary' to show original and retried queries ...................................................................... Patch Set 1: (3 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/16502/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16502/1//COMMIT_MSG@12 PS1, Line 12: ALL The description below indicates that the number of retry is 1. Will we support multiple retries? http://gerrit.cloudera.org:8080/#/c/16502/1/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/16502/1/be/src/service/impala-server.h@802 PS1, Line 802: Status GetExecSummary(const TUniqueId& query_id, const std::string& user, : TExecSummary* result, TExecSummary* original_result = nullptr, : bool* was_retried = nullptr) WARN_UNUSED_RESULT; If multiple retries are planned, then this interface may not be sufficient. An alternative one would be like the following. Status GetExecSummary(const TUniqueId& query_id, const std::string& user, vector<TExecSummary*>& result, enum versions); where versions = ALL, ORIGINAL, LATEST http://gerrit.cloudera.org:8080/#/c/16502/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/16502/1/be/src/service/impala-server.cc@872 PS1, Line 872: CHECK(original_result != nullptr); Seems to me the caller may not be interested to get the summary for the original query. It is better to if ( original_result ) ... ... -- To view, visit http://gerrit.cloudera.org:8080/16502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8605dd0eb2d3a2f64f154afb6c2fd34251c1fec2 Gerrit-Change-Number: 16502 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2020 15:10:09 +0000 Gerrit-HasComments: Yes
