Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16502 )
Change subject: IMPALA-9870: impala-shell 'summary' to show original and retried queries ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16502/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/16502/2/be/src/service/impala-hs2-server.cc@1020 PS2, Line 1020: bool was_retried; nit: I think the standard pattern in Impala is to initialize bools to false -- To view, visit http://gerrit.cloudera.org:8080/16502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8605dd0eb2d3a2f64f154afb6c2fd34251c1fec2 Gerrit-Change-Number: 16502 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Oct 2020 19:12:28 +0000 Gerrit-HasComments: Yes
