Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 )
Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16512/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16512/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@244 PS1, Line 244: latestPartitionSpecId_ = metadata.defaultSpecId(); > Can we have more comments here? The field name is 'latestPartitionSpecId_', Yeah, I think we should use the same vocabulary that Iceberg uses. -- To view, visit http://gerrit.cloudera.org:8080/16512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4c43b75057807ab513a220d348155be2487e714 Gerrit-Change-Number: 16512 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2020 12:20:29 +0000 Gerrit-HasComments: Yes
