Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 )
Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16512/1/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java: http://gerrit.cloudera.org:8080/#/c/16512/1/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java@79 PS1, Line 79: public String toSql(ToSqlOptions options) { : StringBuilder builder = new StringBuilder(); : builder.append(origFieldName_+ " " + fieldType_.toString()); : return builder.toString(); : } : : public TIcebergPartitionField toThrift() { : TIcebergPartitionField result = new TIcebergPartitionField(); : result.setField_id(fieldId_); : > I mean can we add a new field such as 'columnName_' to record source column Thanks for the explanation! What you're saying totally makes sense and I think it should be part of this patch. I made the related changes to introduce a new field for the original field name and to populate it from Iceberg. -- To view, visit http://gerrit.cloudera.org:8080/16512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4c43b75057807ab513a220d348155be2487e714 Gerrit-Change-Number: 16512 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2020 11:53:21 +0000 Gerrit-HasComments: Yes
