Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16506 )
Change subject: IMPALA-9180 (part 2): Refactor executor_list_ map of ExecuterBlacklist ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16506/2/be/src/scheduling/executor-blacklist.cc File be/src/scheduling/executor-blacklist.cc: http://gerrit.cloudera.org:8080/#/c/16506/2/be/src/scheduling/executor-blacklist.cc@52 PS2, Line 52: entry.state = State::BLACKLISTED; : entry.blacklist_time_ms = MonotonicMillis(); : entry.cause = cause; > Could you also briefly mention this change in the commit message for clarit Done. http://gerrit.cloudera.org:8080/#/c/16506/2/be/src/util/uid-util.h File be/src/util/uid-util.h: http://gerrit.cloudera.org:8080/#/c/16506/2/be/src/util/uid-util.h@133 PS2, Line 133: struct UniqueIdPBEqual { : bool operator()(const UniqueIdPB& l_uid, const UniqueIdPB& r_uid) const { : return l_uid.lo() == r_uid.lo() && l_uid.hi() == r_uid.hi(); : } : }; > I think you can just use what's already defined in container-util.h Did not find the equivalent structure for UniqueIdPB in container-util.h. Moved this structure to container-util.h. -- To view, visit http://gerrit.cloudera.org:8080/16506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ae082d0e080088756af91b5b770752ca8b3aa1 Gerrit-Change-Number: 16506 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2020 01:59:05 +0000 Gerrit-HasComments: Yes
