Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16506 )
Change subject: IMPALA-9180 (part 2): Refactor executor_list_ map of ExecuterBlacklist ...................................................................... Patch Set 5: (4 comments) Sorry I was not able to finish the review before Thomas' +2. http://gerrit.cloudera.org:8080/#/c/16506/5/be/src/scheduling/executor-blacklist.h File be/src/scheduling/executor-blacklist.h: http://gerrit.cloudera.org:8080/#/c/16506/5/be/src/scheduling/executor-blacklist.h@136 PS5, Line 136: executor nit. executor->'executor entry' http://gerrit.cloudera.org:8080/#/c/16506/5/be/src/scheduling/executor-blacklist.h@137 PS5, Line 137: blacklisted : /// and ones that are on probation nit: either blacklisted or on probation. http://gerrit.cloudera.org:8080/#/c/16506/5/be/src/scheduling/executor-blacklist.cc File be/src/scheduling/executor-blacklist.cc: http://gerrit.cloudera.org:8080/#/c/16506/5/be/src/scheduling/executor-blacklist.cc@51 PS5, Line 51: int64_t elapsed = MonotonicMillis() - entry.blacklist_time_ms; : entry.state = State::BLACKLISTED; : entry.blacklist_time_ms = MonotonicMillis(); : entry.cause = cause; Should MonotonicMillis() be called only once? That is, in a single time point, we update the entry. I think it would make things clear logically. http://gerrit.cloudera.org:8080/#/c/16506/5/be/src/scheduling/executor-blacklist.cc@164 PS5, Line 164: "on probation") Should we also check on NOT_BLACKLISTED here? -- To view, visit http://gerrit.cloudera.org:8080/16506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ae082d0e080088756af91b5b770752ca8b3aa1 Gerrit-Change-Number: 16506 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2020 18:51:03 +0000 Gerrit-HasComments: Yes
