Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16534 )
Change subject: IMPALA-10205: Replace MD5 hash with SHA-512 for generating datafile path hash ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16534/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16534/1//COMMIT_MSG@11 PS1, Line 11: MD5 with FIPS-approved algorithm SHA-512. The current code that uses MD5 doesn't hash for cryptographic reasons, but only to get a shorter string from the file path that can be used in lookup tables. Are we restricted to FIPS-approved hash algorithms in such cases as well? (I'd think it's just an internal implementation detail. E.g. hash tables also use all kinds of hash algorithms internally that are not approved by FIPS). If so, I see that only SHA algorithms are approved by FIPS. I think SHA-512 is an overkill for our use case. How about SHA-1 or SHA-256? Or maybe we could just use the file path without any hashing. -- To view, visit http://gerrit.cloudera.org:8080/16534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7c805f2fdf0cf5a69738579c7e55f4bd047ed59 Gerrit-Change-Number: 16534 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2020 08:41:17 +0000 Gerrit-HasComments: Yes
