Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16534 )
Change subject: IMPALA-10205: Replace MD5 hash with SHA-512 for generating datafile path hash ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16534/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16534/1//COMMIT_MSG@11 PS1, Line 11: MD5 with FIPS-approved algorithm SHA-512. > The current code that uses MD5 doesn't hash for cryptographic reasons, but The FIPS Support document, which I forwarded to you in email, says "Using only FIPS-approved algorithms. The most common forbidden algorithms are MD5 and RC4. Note that the CryptoComply libraries have no way of distinguishing between MD5 being used for non-security purposes versus security purposes, so avoid all use of forbidden algorithms." So we cannot use MD5 for non-security purposes, like hash map. The document list approved hash algorithms. It suggests to avoid SHA-1, SHA-224, SHA-256 since these algorithms are soon to be deprecated. -- To view, visit http://gerrit.cloudera.org:8080/16534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7c805f2fdf0cf5a69738579c7e55f4bd047ed59 Gerrit-Change-Number: 16534 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2020 16:40:45 +0000 Gerrit-HasComments: Yes
