Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16548 )
Change subject: IMPALA-10219: Add query option to simulate HDFS listing delay ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16548/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16548/2//COMMIT_MSG@10 PS2, Line 10: SIMULATE_CATALOGD_HDFS_LISTING_DELAY_MS Couldn't we use DEBUG_ACTION in the frontend similarly to delay/failure injection to the backend? E.g. CATALOGD_HDFS_LISTING:SLEEP@1000 This may be more work now, but similar delays could be implemented with much less plumbing in the future. I am ok with the current solution if we need to merge this quickly, but I think it worth a TODO, as in the long term DEBUG_ACTION seems better to me. http://gerrit.cloudera.org:8080/#/c/16548/2/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/16548/2/be/src/util/backend-gflag-util.cc@89 PS2, Line 89: DECLARE_int64(catalog_simulate_hdfs_listing_delay_ms); What is the relation of the query option and the flag? I ran through the code and tests and didn't see any usage of the flag. The commit message also doesn't mention it. http://gerrit.cloudera.org:8080/#/c/16548/2/tests/custom_cluster/test_topic_update_frequency.py File tests/custom_cluster/test_topic_update_frequency.py: http://gerrit.cloudera.org:8080/#/c/16548/2/tests/custom_cluster/test_topic_update_frequency.py@24 PS2, Line 24: CustomClusterTestSuite Does this has to be a custom cluster test? I agree that this should be a serialized test, but I don't see why would we need to restart the cluster. -- To view, visit http://gerrit.cloudera.org:8080/16548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7196b1ce76415a5faf3fa8575a26d22b2bf50b1 Gerrit-Change-Number: 16548 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2020 19:37:46 +0000 Gerrit-HasComments: Yes
