Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16548 )
Change subject: IMPALA-10219: Add query option to simulate HDFS listing delay ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16548/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16548/2//COMMIT_MSG@10 PS2, Line 10: SIMULATE_CATALOGD_HDFS_LISTING_DELAY_MS > I meant "...in the catalog service" A pointer for debug actions - this is where they are actually implemented: https://github.com/apache/impala/blob/master/be/src/util/debug-util.cc#L354 SLEEP is good for what we want here - the others could be implemented later when they are actually needed. http://gerrit.cloudera.org:8080/#/c/16548/2/tests/custom_cluster/test_topic_update_frequency.py File tests/custom_cluster/test_topic_update_frequency.py: http://gerrit.cloudera.org:8080/#/c/16548/2/tests/custom_cluster/test_topic_update_frequency.py@24 PS2, Line 24: CustomClusterTestSuite > This change was done to simulate certain conditions for development of patc It doesn't have to be a custom cluster test for debug actions, as debug_actions is a query option. The test should be marked with @pytest.mark.execute_serially though to avoid interfering with parallel tests by locking catalog for a long time. It can stay as a custom_cluster test if it makes merging with https://gerrit.cloudera.org/#/c/16549/ easier, and we can speed up the test later by making it non custom cluster if it turns out to be possible. -- To view, visit http://gerrit.cloudera.org:8080/16548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7196b1ce76415a5faf3fa8575a26d22b2bf50b1 Gerrit-Change-Number: 16548 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2020 23:23:22 +0000 Gerrit-HasComments: Yes
