Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16182 )
Change subject: IMPALA-9974: Join elimination based on referential integrity. ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/main/java/org/apache/impala/planner/JoinNode.java@292 PS4, Line 292: EqJoinConjunctScanSlots slots = EqJoinConjunctScanSlots.create(eqJoinConjunct, analyzer); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/main/java/org/apache/impala/planner/JoinNode.java@478 PS4, Line 478: return new EqJoinConjunctScanSlots(eqJoinConjunct, lhsScanSlot, rhsScanSlot, analyzer); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@523 PS4, Line 523: FeFsTable p2 = (FeFsTable) catalog_.getOrLoadTable("functional", "parent_table_2", "test", null); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@532 PS4, Line 532: FeFsTable child = (FeFsTable) catalog_.getOrLoadTable("functional", "child_table", "test", null); line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd07d45e419175af7d62f6035ba51be841ebc074 Gerrit-Change-Number: 16182 Gerrit-PatchSet: 4 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 07 Oct 2020 04:02:31 +0000 Gerrit-HasComments: Yes
