Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16182 )
Change subject: IMPALA-9974: Join elimination based on referential integrity. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16182/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16182/4//COMMIT_MSG@31 PS4, Line 31: Some TPC-DS 30TB Performance Improvements: > Very nice ! Sorry for the delay in reviewing ! I did a first pass of the code changes only and left a few comments. I haven't yet looked at the tests. Will try to find some cycles to look at those. -- To view, visit http://gerrit.cloudera.org:8080/16182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd07d45e419175af7d62f6035ba51be841ebc074 Gerrit-Change-Number: 16182 Gerrit-PatchSet: 4 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 16 Oct 2020 22:18:21 +0000 Gerrit-HasComments: Yes
