wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16551 )
Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables ...................................................................... Patch Set 2: (6 comments) Please add some test cases in iceberg-negative.test http://gerrit.cloudera.org:8080/#/c/16551/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16551/2//COMMIT_MSG@9 PS2, Line 9: This patch adds support for Iceberg Bucket and Truncate partition : transforms. Both accept a parameter: number of buckets and width : respectively. : : Usage: : CREATE TABLE tbl_name (i int, p1 int, p2 timestamp) : PARTITION BY SPEC ( : p1 BUCKET 10, : p1 TRUNCATE 5 : ) STORED AS ICEBERG : TBLPROPERTIES ('iceberg.catalog'='hadoop.tables'); I saw you add test cases, maybe add some messages about test info? such as: Testing: - Create table tests in functional_schema_template.sql - Iceberg table create test in test_iceberg.py - Iceberg table query test in test_scanners.py - Iceberg table show create table test in test_show_create_table.py http://gerrit.cloudera.org:8080/#/c/16551/2/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/16551/2/common/thrift/CatalogObjects.thrift@527 PS2, Line 527: transform_param Maybe add some explains for this variable, since this variable is only valid for truncate and bucket. http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java: http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java@42 PS2, Line 42: Column partition type IcebergPartitionTransform class is not only partition type, but also contains param. http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java: http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java@54 PS2, Line 54: ONLY nit: Only http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@247 PS2, Line 247: iceberg nit: Iceberg http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2989 PS2, Line 2989: ParserError("CREATE TABLE tbl1 (i int, p1 int) PARTITION BY SPEC (p1 TRUNCATE) " + : "STORED AS ICEBERG TBLPROPERTIES ('iceberg.catalog'='hadoop.tables')"); Also add a test for 'BUCKET' -- To view, visit http://gerrit.cloudera.org:8080/16551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc75cd23045b274885607c45886319f4f6da19de Gerrit-Change-Number: 16551 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 09 Oct 2020 08:24:26 +0000 Gerrit-HasComments: Yes
