wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16551 )
Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Thanks for change, LGTM, just a small nit. http://gerrit.cloudera.org:8080/#/c/16551/4/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/16551/4/common/thrift/CatalogObjects.thrift@527 PS4, Line 527: // Parameter for BUCKET and TRUNCATE transforms. I'm not sure if it is better to put the comment on a new line, just like other comment. -- To view, visit http://gerrit.cloudera.org:8080/16551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc75cd23045b274885607c45886319f4f6da19de Gerrit-Change-Number: 16551 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 09 Oct 2020 12:14:43 +0000 Gerrit-HasComments: Yes
