Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16575 )
Change subject: IMPALA-10152: part 1: refactor Iceberg catalog handling ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16575/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16575/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1907 PS2, Line 1907: IcebergCatalogOpExecutor.dropTable((IcebergTable)existingTbl, params.if_exists); > For the current filesystem-based catalogs (HadoopTables and HadoopCatalog) No strong feelings from my side just wanted to check that this is intentional. What do you think about adding a small comment about this in the commit msg? -- To view, visit http://gerrit.cloudera.org:8080/16575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie69dff6cd6b8b3dc0ba5f7671b8504a936032a85 Gerrit-Change-Number: 16575 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 13 Oct 2020 07:54:41 +0000 Gerrit-HasComments: Yes
