Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16575 )
Change subject: IMPALA-10152: part 1: refactor Iceberg catalog handling ...................................................................... Patch Set 4: (1 comment) Thanks for catching this. Fortunately, if anything had happened between step 1 and 2, e.g. SHOW FILES, SELECT, etc., then the DROP TABLE would have succeeded. But still, we should be able to DROP incomplete tables in all cases. http://gerrit.cloudera.org:8080/#/c/16575/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16575/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1906 PS4, Line 1906: Preconditions.checkState(existingTbl instanceof IcebergTable); > I found a bug, here is the reproduce steps: Thanks for the notice, I've fixed it and also added a test for it. -- To view, visit http://gerrit.cloudera.org:8080/16575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie69dff6cd6b8b3dc0ba5f7671b8504a936032a85 Gerrit-Change-Number: 16575 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 13 Oct 2020 16:30:58 +0000 Gerrit-HasComments: Yes
