Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16602 )
Change subject: IMPALA-10243: ConcurrentModificationException during parallel INSERTs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16602/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16602/1//COMMIT_MSG@9 PS1, Line 9: ConcurrentModificationException > Can you add the full callstack somewhere,e.g. in the Jira? It would be good I updated the Jira description. http://gerrit.cloudera.org:8080/#/c/16602/1//COMMIT_MSG@15 PS1, Line 15: This can potentially happen in CatalogOpExecutor.updateCatalog() which : updates the catalog version and unsets table column statistics. > tldr: I would prefer to threat msTable as immutable and deepcopy it where w Setting a mutable object in toThrift() is not a good idea IMO, as nothing would prevent such errors in the future. In the past we also had a very similar issue: IMPALA-4902, and the solution was also to make a copy. I agree that creating a deep copy of the metastore table whenever we modify it would be good practice. The problem is that we cannot enforce it. I can modify updateCatalog() in the context of this Jira, but I feel that it is a bit different problem. I think it would better fit another Jira that would be about deep copying the metastore table whenever possible, not just in updateCatalog(). -- To view, visit http://gerrit.cloudera.org:8080/16602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie656925d764d5eb26c318703ca425529ecf7a3a3 Gerrit-Change-Number: 16602 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 15 Oct 2020 11:58:02 +0000 Gerrit-HasComments: Yes
