Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16602 )
Change subject: IMPALA-10243: ConcurrentModificationException during parallel INSERTs ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16602/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16602/1//COMMIT_MSG@15 PS1, Line 15: This can potentially happen in CatalogOpExecutor.updateCatalog() which : updates the catalog version and unsets table column statistics. > Setting a mutable object in toThrift() is not a good idea IMO, as nothing w Ok, this can go in as it is, and extra deepcopy shouldn't hurt, as msTable shouldn't be too large. Some comment about the cause of the issue would be nice. Btw I found another place that modifies msTable without deepcopy: https://github.com/apache/impala/blame/master/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L1037 This seems more complex to fix than unsetTableColStats(). -- To view, visit http://gerrit.cloudera.org:8080/16602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie656925d764d5eb26c318703ca425529ecf7a3a3 Gerrit-Change-Number: 16602 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 15 Oct 2020 14:33:02 +0000 Gerrit-HasComments: Yes
