Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16599 )

Change subject: IMPALA-10153: Implement SHOW TABLE HISTORY for Iceberg tables
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16599/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16599/1//COMMIT_MSG@17
PS1, Line 17: 2020-10-13 14:01:07.234000
Does Spark 'select * from table.history' show the same timestamp values? I 
suppose the timestamp is stored in UTC, does Impala convert it to local 
timezone?


http://gerrit.cloudera.org:8080/#/c/16599/1//COMMIT_MSG@24
PS1, Line 24: bacis
nit: basic


http://gerrit.cloudera.org:8080/#/c/16599/1//COMMIT_MSG@24
PS1, Line 24: SHOW CREATE
            :     TABLE
SHOW TABLE HISTORY?


http://gerrit.cloudera.org:8080/#/c/16599/1/testdata/data/README
File testdata/data/README:

http://gerrit.cloudera.org:8080/#/c/16599/1/testdata/data/README@578
PS1, Line 578:
Please extend this file with the newly added Iceberg table.



--
To view, visit http://gerrit.cloudera.org:8080/16599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a4b92c27e8e4a79109696cbae62735a00750e5
Gerrit-Change-Number: 16599
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
Gerrit-Comment-Date: Thu, 22 Oct 2020 13:42:39 +0000
Gerrit-HasComments: Yes

Reply via email to