Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 )
Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/16599/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/16599/2/be/src/service/client-request-state.cc@426 PS2, Line 426: SHOW_TABLE_HISTORY Should be DESCRIBE_HISTORY http://gerrit.cloudera.org:8080/#/c/16599/2/be/src/service/frontend.h File be/src/service/frontend.h: http://gerrit.cloudera.org:8080/#/c/16599/2/be/src/service/frontend.h@99 PS2, Line 99: CALL nit: typo http://gerrit.cloudera.org:8080/#/c/16599/2/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/16599/2/common/thrift/Frontend.thrift@292 PS2, Line 292: SHOW CREATE TABLE DESCRIBE HISTORY http://gerrit.cloudera.org:8080/#/c/16599/2/fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java: http://gerrit.cloudera.org:8080/#/c/16599/2/fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java@31 PS2, Line 31: SHOW TABLE HISTORY DESCRIBE HISTORY http://gerrit.cloudera.org:8080/#/c/16599/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/16599/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1077 PS2, Line 1077: SHOW TABLE HISTORY DESCRIBE HISTORY -- To view, visit http://gerrit.cloudera.org:8080/16599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a4b92c27e8e4a79109696cbae62735a00750e5 Gerrit-Change-Number: 16599 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 30 Oct 2020 13:44:45 +0000 Gerrit-HasComments: Yes
