Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 )
Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ...................................................................... Patch Set 12: (1 comment) This is starting to get clearer to me. I think I'm a couple more chunks of time away from having more comments. I have one comment right now, but don't feel obligated to address it until I come back with more. http://gerrit.cloudera.org:8080/#/c/16057/12/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/16057/12/be/src/util/runtime-profile.cc@177 PS12, Line 177: // Search forward until the insert position is either at the end of the vector : // or after this child. This preserves the order if the relative order of : // children in all updates is consistent. : bool found_child = false; Are there cases that actually hit the children_.end() without finding the child? Could we safely DCHECK that found_child=true? -- To view, visit http://gerrit.cloudera.org:8080/16057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic680cbfe94c939c2a8fad9d0943034ed058c6bca Gerrit-Change-Number: 16057 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 23 Oct 2020 21:12:07 +0000 Gerrit-HasComments: Yes
