Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 )
Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/16057/12/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/16057/12/be/src/util/runtime-profile.h@833 PS12, Line 833: struct AggEventSequence { : // Unique labels in the event sequence. Values are [0, labels.size() - 1] : std::map<std::string, int32_t> labels; : : // One entry per instance. Each entry contains the label indices for that instance's : // event sequence. : std::vector<std::vector<int32_t>> label_idxs; : : // One entry per instance. Each entry contains the timestamps for that instance's : // event sequence. : std::vector<std::vector<int64_t>> timestamps; : }; : : std::map<std::string, AggEventSequence> event_sequence_map_; : : /// Protects event_sequence_map_ and event_sequence_labels_. : mutable SpinLock event_sequence_lock_; : : /// Time series counters. Protected by 'counter_map_lock_'. : std::map<std::string, TAggTimeSeriesCounter> time_series_counter_map_; > Something we need to consider is how to test for correctness on the aggrega I added some unit tests that take the various object types, then put them through the two different types of Update methods and then sanity check the thrift output. I think this provides a good level of sanity checking. -- To view, visit http://gerrit.cloudera.org:8080/16057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic680cbfe94c939c2a8fad9d0943034ed058c6bca Gerrit-Change-Number: 16057 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 14 Nov 2020 04:50:23 +0000 Gerrit-HasComments: Yes
