Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16638 )
Change subject: IMPALA-10102 Fix Impalad crashes when writing a parquet file with large rows. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16638/2/be/src/runtime/mem-pool.h File be/src/runtime/mem-pool.h: http://gerrit.cloudera.org:8080/#/c/16638/2/be/src/runtime/mem-pool.h@312 PS2, Line 312: #define RETURN_STATUS_IF_ALLOC_NULL(alloc, alloc_size, pool) \ I believe #defines are generally discouraged in headers and inline functions are preferred instead. http://gerrit.cloudera.org:8080/#/c/16638/2/be/src/runtime/mem-pool.h@315 PS2, Line 315: return pool->mem_tracker()->MemLimitExceeded(nullptr, details, (alloc_size)); \ I think, you could also pass the RuntimeState* instead of nullptr here. In this particular case the caller can pass the 'state_' which it inherits from its base class. -- To view, visit http://gerrit.cloudera.org:8080/16638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dee474cceb0c370278d290eb900c05769b23dec Gerrit-Change-Number: 16638 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 23 Oct 2020 23:17:36 +0000 Gerrit-HasComments: Yes
