Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13342 )
Change subject: WIP: IMPALA-9773: Temporal (ASOF) query support for Kudu tables ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13342/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/13342/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java@166 PS2, Line 166: public TableRef(List<String> path, String alias, TableSampleClause tableSample, Expr asOfExpr) { > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/13342/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java@423 PS2, Line 423: throw new AnalysisException("AS OF TIMESTAMP expression must be a constant expression: " + > line too long (96 > 90) Done http://gerrit.cloudera.org:8080/#/c/13342/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java@427 PS2, Line 427: throw new AnalysisException("AS OF TIMESTAMP expression must be a timestamp type but is '" + > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/13342/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java@433 PS2, Line 433: throw new AnalysisException("Invalid AS OF TIMESTAMP expression: " + ie.getMessage()); > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/13342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I939898548c307810d509cf486e2c0f1f335a5ac4 Gerrit-Change-Number: 13342 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nong Li (20) Gerrit-Comment-Date: Fri, 30 Oct 2020 21:07:10 +0000 Gerrit-HasComments: Yes
