Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13342 )
Change subject: WIP: IMPALA-9773: Temporal (ASOF) query support for Kudu tables ...................................................................... Patch Set 6: (1 comment) Cool! left a couple of notes about the syntax, understand it's a WIP so maybe you're already thinking along the same lines. http://gerrit.cloudera.org:8080/#/c/13342/6/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/13342/6/fe/src/main/cup/sql-parser.cup@3088 PS6, Line 3088: KW_ASOF KW_TIMESTAMP expr:expr I think it'd be best to use the SQL standard "FOR SYSTEM_TIME AS OF" unless there's a specific reason to do something non standard. Sec 2.3.2 here https://sigmodrecord.org/publications/sigmodRecord/1209/pdfs/07.industry.kulkarni.pdf We also shouldn't need the TIMESTAMP token here - we really should be supporting standard timestamp literals with that prefix - IMPALA-4017 It's probably OK if you want to leave the TIMESTAMP token, but it'd be good to leave a reference to IMPALA-4017 noting that it should be removed when that's implemented. -- To view, visit http://gerrit.cloudera.org:8080/13342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I939898548c307810d509cf486e2c0f1f335a5ac4 Gerrit-Change-Number: 13342 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sat, 31 Oct 2020 00:01:14 +0000 Gerrit-HasComments: Yes
