Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset ...................................................................... Patch Set 1: (3 comments) Hi Shajini, thank you for the change. I have left some comments inline. http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1390 PS1, Line 1390: TZ To keep the document's consistency, could you change "TZ" to "timezone". http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1416 PS1, Line 1416: /> There is a similar usage note already in place here (timezone_conversion_caveat), I think the 'Usage notes' would be a better place for the new paragraph. Also instead of <note> it could be <p>. http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1420 PS1, Line 1420: nit: empty tab -- To view, visit http://gerrit.cloudera.org:8080/16689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1 Gerrit-Change-Number: 16689 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 10:56:27 +0000 Gerrit-HasComments: Yes
