Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1390 PS1, Line 1390: TZ > To keep the document's consistency, could you change "TZ" to "timezone". I think the issues with FROM_UNIXTIME() is not that Impala doesn't store timezone information internally, but that this particular function receives a bigint number (seconds since epoch) as an input and that doesn't hold any TZ info. This comment you wrote would be a good one for any other timstamp conversion functions that receive a timestamp and returns a formatted string. -- To view, visit http://gerrit.cloudera.org:8080/16689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1 Gerrit-Change-Number: 16689 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Nov 2020 16:06:39 +0000 Gerrit-HasComments: Yes
