Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 )
Change subject: IMPALA-10314: Optimize planning time for simple limits ...................................................................... Patch Set 9: > Patch Set 8: > > > Patch Set 8: > > > > > Patch Set 8: > > > > > > > Patch Set 8: Verified-1 > > > > > > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6687/ > > > > > > There's 1 failure: > > > [gw1] FAILED > > > query_test/test_exprs.py::TestExprLimits::test_statement_expression_limit > > > > > > However, on my desktop I ran query_test/test_exprs.py and all tests under > > > it passed. > > > > On Jenkins this test hit an OOM GC overhead limit exceeded: > > gw1] linux2 -- Python 2.7.16 > > /home/ubuntu/Impala/bin/../infra/python/env-gcc7.5.0/bin/python > > query_test/test_exprs.py:176: in test_statement_expression_limit > > assert re.search(expected_err_re, str(err)) > > E assert None > > E + where None = <function search at 0x7fc9ff90e848>('Exceeded the > > statement expression limit \\(250000\\)\nStatement has .* expressions.', > > "ImpalaBeeswaxException:\n INNER EXCEPTION: <class > > 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: OutOfMemoryError: GC > > overhead limit exceeded\n") > > E + where <function search at 0x7fc9ff90e848> = re.search > > E + and "ImpalaBeeswaxException:\n INNER EXCEPTION: <class > > 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: OutOfMemoryError: GC > > overhead limit exceeded\n" = str(ImpalaBeeswaxException()) > > Oh wait, there's actually another failure in FE: > > 23:47:52 [INFO] Running org.apache.impala.analysis.ParserTest > 23:47:52 [ERROR] Tests run: 98, Failures: 1, Errors: 0, Skipped: 0, Time > elapsed: 0.829 s <<< FAILURE! - in org.apache.impala.analysis.ParserTest > 23:47:52 [ERROR] TestGetErrorMsg(org.apache.impala.analysis.ParserTest) Time > elapsed: 0.005 s <<< FAILURE! > at > org.apache.impala.analysis.ParserTest.ParserError(ParserTest.java:77) > at > org.apache.impala.analysis.ParserTest.TestGetErrorMsg(ParserTest.java:3475) > > Will need to look into this one. PS9 fixes the ParserTest issue..just had to update the list of expected keywords in the test after a WHERE clause. Not yet sure about the other OOM failure since I cannot repro locally. -- To view, visit http://gerrit.cloudera.org:8080/16723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d6a79263bc092e0f3e9a1d72da5618f3cc35574 Gerrit-Change-Number: 16723 Gerrit-PatchSet: 9 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 21 Nov 2020 03:58:04 +0000 Gerrit-HasComments: No
